Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-drupal): Add timeout in case of stalled API requests #33668

Merged
merged 3 commits into from
Oct 26, 2021
Merged

fix(gatsby-source-drupal): Add timeout in case of stalled API requests #33668

merged 3 commits into from
Oct 26, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Oct 25, 2021 •
edited
Loading

We observe stalled API requests sometimes on customer sites. Adding a timeout ensures these don't block sourcing.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 25, 2021
@KyleAMathews KyleAMathews added topic: source-drupal Related to Gatsby's integration with Drupal type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 25, 2021
KyleAMathews
KyleAMathews commented Oct 25, 2021
View reviewed changes
packages/gatsby-source-drupal/src/gatsby-node.js
@@ -253,7 +257,7 @@ ${JSON.stringify(webhookBody, null, 4)}`

// lastFetched isn't set so do a full rebuild.
if (!lastFetched) {
setPluginStatus({ lastFetched: new Date().getTime() })
setPluginStatus({ lastFetched: Math.floor(new Date().getTime() / 1000) })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix the timestamp creation as JS uses milliseconds and PHP uses seconds.

@KyleAMathews KyleAMathews added this to To cherry-pick in V3 Release Hotfixes via automation Oct 25, 2021
vladar
vladar approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vladar vladar merged commit 113ae43 into master Oct 26, 2021
@vladar vladar deleted the drupal-updates branch October 26, 2021 08:35
@gatsbybot gatsbybot mentioned this pull request Oct 27, 2021
Merged
vladar pushed a commit that referenced this pull request Oct 27, 2021
@KyleAMathews @vladar
fix(gatsby-source-drupal): Add timeout in case of stalled API requests (
0781c73 
#33668)

* feat(gatsby-source-drupal): More ports from customer fixes

* cleanups

(cherry picked from commit 113ae43)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Oct 27, 2021
vladar pushed a commit that referenced this pull request Oct 28, 2021
@KyleAMathews
fix(gatsby-source-drupal): Add timeout in case of stalled API requests (
4722a0d 
#33668) (#33705)

* feat(gatsby-source-drupal): More ports from customer fixes

* cleanups

(cherry picked from commit 113ae43)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Oct 28, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes Oct 28, 2021
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
@KyleAMathews @wardpeet
fix(gatsby-source-drupal): Add timeout in case of stalled API requests (
2bb3aef 
gatsbyjs#33668)

* feat(gatsby-source-drupal): More ports from customer fixes

* cleanups
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
@KyleAMathews @axe312ger
fix(gatsby-source-drupal): Add timeout in case of stalled API requests (
5ef6d62 
#33668)

* feat(gatsby-source-drupal): More ports from customer fixes

* cleanups
@KyleAMathews KyleAMathews mentioned this pull request Nov 22, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 6, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 6, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 6, 2022
Open
This was referenced Jun 6, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 7, 2022
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
topic: source-drupal Related to Gatsby's integration with Drupal type: bug An issue or pull request relating to a bug in Gatsby
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KyleAMathews @vladar