Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-drupal): Add missing params from options to API urls #33861

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix(gatsby-source-drupal): Add missing params from options to API urls #33861

merged 1 commit into from
Nov 4, 2021

Conversation

jstramel
Copy link
Contributor

@jstramel jstramel commented Nov 4, 2021 •
edited by KyleAMathews
Loading

Fixes issue where params such as api-key were not added correctly to the API URL.

@jstramel
searcParams missing from urls
ecb95aa 
- Fix issue where params such as api-key are not added to the url
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2021
KyleAMathews
KyleAMathews approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@KyleAMathews KyleAMathews changed the title gatsby-source-drupal: searchParams missing from urls fix(gatsby-source-drupal): Add missing params from options to API urls Nov 4, 2021
@KyleAMathews KyleAMathews added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 4, 2021
@KyleAMathews KyleAMathews merged commit c9a35ed into gatsbyjs:master Nov 4, 2021
@KyleAMathews KyleAMathews added this to To cherry-pick in V3 Release Hotfixes via automation Nov 4, 2021
@KyleAMathews KyleAMathews added this to To cherry-pick in V4 Release hotfixes via automation Nov 4, 2021
@gatsbybot gatsbybot mentioned this pull request Nov 8, 2021
Merged
LekoArts pushed a commit that referenced this pull request Nov 8, 2021
@jstramel @LekoArts
searcParams missing from urls (#33861)
91ad295 
- Fix issue where params such as api-key are not added to the url

(cherry picked from commit c9a35ed)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Nov 8, 2021
LekoArts pushed a commit that referenced this pull request Nov 8, 2021
@jstramel
searcParams missing from urls (#33861) (#33895)
60de482 
Co-authored-by: Joe Stramel <jstramel@users.noreply.github.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in V4 Release hotfixes Nov 8, 2021
@LekoArts LekoArts moved this from Backported to Published in V4 Release hotfixes Nov 8, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Nov 8, 2021

Published in gatsby-source-drupal@5.1.1

axe312ger pushed a commit that referenced this pull request Nov 9, 2021
@jstramel @axe312ger
searcParams missing from urls (#33861)
fb8af7d 
- Fix issue where params such as api-key are not added to the url
@gatsbybot gatsbybot mentioned this pull request Nov 18, 2021
Merged
vladar pushed a commit that referenced this pull request Nov 18, 2021
@jstramel @vladar
searcParams missing from urls (#33861)
688376b 
- Fix issue where params such as api-key are not added to the url

(cherry picked from commit c9a35ed)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Nov 18, 2021
vladar pushed a commit that referenced this pull request Nov 18, 2021
@jstramel
fix(gatsby-source-drupal): searcParams missing from urls (#33861) (#3…
76deb39 
…4018)

- Fix issue where params such as api-key are not added to the url

(cherry picked from commit c9a35ed)

Co-authored-by: Joe Stramel <jstramel@users.noreply.github.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Nov 18, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes Nov 18, 2021
@snyk-bot snyk-bot mentioned this pull request Jun 6, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 6, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 6, 2022
Open
This was referenced Jun 6, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
topic: source-drupal Related to Gatsby's integration with Drupal
Projects
V4 Release hotfixes
Published
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jstramel @LekoArts @KyleAMathews