Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): ensure that writing node manifests to disk does not break on Windows (#33853) #34020

Merged
merged 1 commit into from
Nov 18, 2021

Commits on Nov 18, 2021

  1. fix(gatsby): ensure that writing node manifests to disk does not brea…

    …k on Windows (#33853)
    
    * fix: ensure that writing node manifests to disk does not break on Windows
    
    * refactor: use joinPath helper when creating node manifest file name
    
    * feat: replace all invalid Windows file path chars when creating node manifest files
    
    * test: use joinPath helper in node manifest tests
    
    * feat: only replace special windows chars in the manifest filename
    
    * feat: do not use negative look behind for Windows hard drive name
    
    * test: add tests for windows node manifest file name character replacing
    
    (cherry picked from commit f525ce0)
    veryspry authored and vladar committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    7369e5b View commit details
    Browse the repository at this point in the history