Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-nprogress): Replace nprogress with accessible-nprogress #34038

Merged
merged 2 commits into from Nov 22, 2021
Merged

feat(gatsby-plugin-nprogress): Replace nprogress with accessible-nprogress #34038

merged 2 commits into from Nov 22, 2021

Conversation

pranav0281999
Copy link

@pranav0281999 pranav0281999 commented Nov 20, 2021 •
edited by LekoArts

Description

Replaces nprogress module with accessible-nprogress module to make gatsby-plugin-nprogress more accessible.

If you used the template option you might need to adjust your plugin options to now use className="bar", see: https://github.com/nmackey/accessible-nprogress#template

Related Issues

Fixes #33875

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 20, 2021
@pranav0281999 pranav0281999 changed the title fix(gatsby-plugin-nprogress): Replaces nprogress with accessible-nprogress module #33875 fix(gatsby-plugin-nprogress): Replaces nprogress with accessible-nprogress module Nov 20, 2021
@LekoArts LekoArts changed the title fix(gatsby-plugin-nprogress): Replaces nprogress with accessible-nprogress module feat(gatsby-plugin-nprogress): Replace nprogress with accessible-nprogress Nov 22, 2021
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 22, 2021
LekoArts
LekoArts approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it manually, too. Still works the same.

Thanks!

@LekoArts LekoArts merged commit 3f65d17 into gatsbyjs:master Nov 22, 2021
@LekoArts LekoArts added the topic: a11y Related to accessibility label Nov 22, 2021
@pranav0281999 pranav0281999 deleted the accessible-nprogress branch November 22, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: a11y Related to accessibility topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nprogress accessibility issues
2 participants
@pranav0281999 @LekoArts