Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-gatsby): TypeScript option #34611

Merged
merged 18 commits into from
Feb 8, 2022
Merged

feat(create-gatsby): TypeScript option #34611

merged 18 commits into from
Feb 8, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 28, 2022 •
edited
Loading

Description

Introduce a TS option to the create-gatsby package. Includes:

  • Language section between JS and TS in questionnaire prompt
  • Telemetry for language selection
  • -ts flag option
  • Passing flags without regard for position (e.g. npm init -y gatsby and npm init gatsby -y work the same)
  • Tests for added and existing features

Notes

This depends on the new minimal TS starter to exist to function as expected (sc ticket 44605).

#34688 needs to be merged first.

Documentation

  • Updates the quick start doc to mention language selection in the questionnaire and available flags (-y and -ts)

Related Issues

[sc-44606]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 28, 2022
@tyhopp tyhopp marked this pull request as draft January 28, 2022 06:17
@tyhopp tyhopp added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2022
@tyhopp tyhopp marked this pull request as ready for review January 28, 2022 10:48
@LekoArts LekoArts added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Jan 28, 2022
@LekoArts
Copy link
Contributor

Adding "blocked" to indicate that gatsby-starter-minimal-ts needs to be created first (+ then also change in quick start to accommodate for that)

@tyhopp tyhopp marked this pull request as draft January 28, 2022 12:47
@LekoArts LekoArts removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Feb 3, 2022
LekoArts
LekoArts suggested changes Feb 3, 2022
View reviewed changes
docs/docs/quick-start.md Outdated Show resolved Hide resolved
packages/create-gatsby/src/__tests__/utils/parse-args.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/index.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/__tests__/run.ts Show resolved Hide resolved
@LekoArts LekoArts marked this pull request as ready for review February 7, 2022 13:53
LekoArts
LekoArts previously approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally and works great! Encourage you to also try it out but overall LGTM 🌮

LekoArts
LekoArts approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LekoArts LekoArts merged commit a78ef94 into master Feb 8, 2022
@LekoArts LekoArts deleted the feat-create-gatsby-ts branch February 8, 2022 09:33
wardpeet pushed a commit to wardpeet/gatsby that referenced this pull request Feb 8, 2022
@tyhopp @LekoArts
@marvinjude @wardpeet
feat(create-gatsby): TypeScript option (gatsbyjs#34611)
531c6e0 
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Jude Agboola <marvinjudehk@gmail.com>
@LekoArts LekoArts added this to the TypeScript Improvements milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
TypeScript AOT Compilation
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyhopp @LekoArts @marvinjude