Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable TS for gatsby-browser/gatsby-ssr #34692

Merged
merged 12 commits into from
Feb 8, 2022
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Feb 2, 2022

Description

This enables one to use gatsby-browser.tsx and gatsby-ssr.tsx inside root of page and local plugins.

The production-runtime test also has gatsby-browser.tsx as otherwise there will be a mismatch between HTML and Client and the layout would be completely messed up.

Documentation

Updated the TS doc

Related Issues

[ch44665]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 2, 2022
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 2, 2022
@LekoArts LekoArts marked this pull request as draft February 2, 2022 16:26
@LekoArts LekoArts marked this pull request as ready for review February 7, 2022 13:53
Copy link
Contributor

@imjoshin imjoshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The docs are 🥇

@wardpeet wardpeet merged commit 040603f into master Feb 8, 2022
@wardpeet wardpeet deleted the browser-ssr-tsx branch February 8, 2022 07:52
wardpeet pushed a commit to wardpeet/gatsby that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants