Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-wordpress): enable image-cdn #34832

Merged
merged 41 commits into from
Mar 1, 2022
Merged

feat(gatsby-source-wordpress): enable image-cdn #34832

merged 41 commits into from
Mar 1, 2022

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Feb 16, 2022 •
edited by TylerBarnes

Description

Enables Image CDN for wordpress

  • add support for inline image in body text
  • write tests

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 16, 2022
@wardpeet wardpeet added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 16, 2022
@wardpeet wardpeet changed the title feat(gatsby-core-utils): improve fetch-remote-file feat(gatsby-source-wordpress): enable image-cdn Feb 16, 2022
@wardpeet wardpeet force-pushed the image-cdn branch 3 times, most recently from 84b699e to 8b79034 Compare February 17, 2022 13:58
@wardpeet wardpeet force-pushed the image-cdn branch 3 times, most recently from b0dfb18 to 6ef7bf2 Compare February 23, 2022 15:00
@TylerBarnes TylerBarnes marked this pull request as ready for review February 23, 2022 18:59
veryspry
veryspry previously approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I added some questions but only because I was curious

integration-tests/gatsby-source-wordpress/__tests__/index.js Show resolved Hide resolved
packages/gatsby-source-wordpress/__tests__/process-node.test.js Show resolved Hide resolved
packages/gatsby-source-wordpress/src/steps/declare-plugin-options-schema.js Show resolved Hide resolved
packages/gatsby-source-wordpress/src/steps/declare-plugin-options-schema.js Outdated Show resolved Hide resolved
@wardpeet wardpeet force-pushed the image-cdn branch 2 times, most recently from 524e73a to 0e4dafe Compare March 1, 2022 07:46
@wardpeet wardpeet force-pushed the feat/image-cdn-wordpress branch 2 times, most recently from fe530ba to df10704 Compare March 1, 2022 21:57
Base automatically changed from image-cdn to master March 1, 2022 21:57
@TylerBarnes TylerBarnes self-requested a review March 1, 2022 22:32
TylerBarnes
TylerBarnes previously approved these changes Mar 1, 2022
View reviewed changes
@TylerBarnes TylerBarnes self-requested a review March 1, 2022 22:36
TylerBarnes
TylerBarnes previously approved these changes Mar 1, 2022
View reviewed changes
@TylerBarnes TylerBarnes self-requested a review March 1, 2022 22:47
@wardpeet wardpeet merged commit fe29c01 into master Mar 1, 2022
@wardpeet wardpeet deleted the feat/image-cdn-wordpress branch March 1, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerBarnes TylerBarnes TylerBarnes approved these changes

@veryspry veryspry veryspry left review comments

Assignees
No one assigned
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wardpeet @TylerBarnes @veryspry