Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): wait for LMDB upserts to finish before emitting ENGINES_READY #34853

Merged
merged 9 commits into from
Feb 21, 2022
Merged

fix(gatsby): wait for LMDB upserts to finish before emitting ENGINES_READY #34853

merged 9 commits into from
Feb 21, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 18, 2022

Description

Right now we are emitting ENGINES_READY message (so CI/CD can start handling engines) before all upserts to LMDB happened. Right now it can result in cases where CI/CD and core both try to interact with LMDB and potentially resulting in corrupted DB later when engines are actually used.

This moves known upserts (materializing page mode) and ensurse we are finished with them before ENGINES_READY

Related Issues

[ch-46416]
[ch-44853]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 18, 2022
@pieh pieh marked this pull request as ready for review February 21, 2022 10:37
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 21, 2022
wardpeet
wardpeet previously approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I've added a clarifying question to maybe cleanup the code a bit.

LekoArts
LekoArts previously approved these changes Feb 21, 2022
View reviewed changes
@LekoArts LekoArts added this to To cherry-pick in Release candidate via automation Feb 21, 2022
@pieh pieh merged commit b4637c0 into master Feb 21, 2022
@pieh pieh deleted the fix/materialize-mode-before-engines-ready branch February 21, 2022 13:56
@gatsbybot gatsbybot mentioned this pull request Feb 22, 2022
Merged
tyhopp pushed a commit that referenced this pull request Feb 22, 2022
@pieh @tyhopp
fix(gatsby): wait for LMDB upserts to finish before emitting ENGINES_…
2c2d0e3 
…READY (#34853)

(cherry picked from commit b4637c0)
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in Release candidate Feb 22, 2022
tyhopp pushed a commit that referenced this pull request Feb 22, 2022
@ViCo0TeCH @pieh
fix(gatsby): wait for LMDB upserts to finish before emitting ENGINES_…
9a616c0 
…READY (#34853) (#34896)

(cherry picked from commit b4637c0)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@tyhopp tyhopp moved this from Backport PR opened to Backported in Release candidate Feb 22, 2022
This was referenced May 26, 2022
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
This was referenced May 28, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 28, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 28, 2022
Open
@saurabharch saurabharch mentioned this pull request May 28, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 28, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 28, 2022
Open
This was referenced May 28, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 28, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 29, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 22, 2022
Open
@saurabharch saurabharch mentioned this pull request Jun 22, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 22, 2022
Open
This was referenced Jul 21, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Aug 24, 2022
Open
@monizb monizb mentioned this pull request Feb 16, 2023
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2023
Merged
@0xSebin 0xSebin mentioned this pull request Feb 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2023
Open
This was referenced Mar 28, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pieh @wardpeet @LekoArts