Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-gatsby): Add required deps for theme-ui option #34885

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Feb 21, 2022

Description

Add required dependencies that are no longer deps of the latest version of theme-ui. See https://github.com/system-ui/theme-ui/blob/develop/CHANGELOG.md

Related Issues

Fixes #34882

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 21, 2022
@tyhopp tyhopp linked an issue Feb 21, 2022 that may be closed by this pull request
2 tasks
@tyhopp tyhopp added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 21, 2022
marvinjude
marvinjude previously approved these changes Feb 21, 2022
"theme-ui",
"@emotion/react",
"@emotion/styled",
"@mdx-js/react@v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise v2 would be installed which is ESM only and we currently don't support

@LekoArts LekoArts added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 21, 2022
@gatsbybot gatsbybot merged commit b2c1092 into master Feb 21, 2022
@gatsbybot gatsbybot deleted the fix-create-gatsby-theme-ui branch February 21, 2022 09:31
@tyhopp tyhopp added this to To cherry-pick in Release candidate via automation Feb 22, 2022
@tyhopp tyhopp removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 22, 2022
tyhopp added a commit that referenced this pull request Feb 22, 2022
* fix(create-gatsby): Add required deps for theme-ui option

* Update styles.json

Co-authored-by: Lennart <lekoarts@gmail.com>
(cherry picked from commit b2c1092)
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in Release candidate Feb 22, 2022
tyhopp added a commit that referenced this pull request Feb 22, 2022
…34897)

* fix(create-gatsby): Add required deps for theme-ui option

* Update styles.json

Co-authored-by: Lennart <lekoarts@gmail.com>
(cherry picked from commit b2c1092)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
@tyhopp tyhopp moved this from Backport PR opened to Backported in Release candidate Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

"npm init gatsby" w/ theme-ui fails to start as it requires emotion/mdx
4 participants