Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-preact): fix preact alias #35156

Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix(gatsby-plugin-preact): fix preact alias #35156

merged 1 commit into from
Mar 18, 2022

Conversation

wardpeet
Copy link
Contributor

Description

Fixes aliases in Preact
https://preactjs.com/guide/v10/getting-started/#aliasing-react-to-preact

Documentation

Related Issues

Fixes #35145

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 17, 2022
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 17, 2022
@LekoArts
Copy link
Contributor

The pnp tests is always failing at the moment so it's hard to see if this change would break pnp :/

@wardpeet
Copy link
Contributor Author

It won't because webpack will go through pnp

marvinjude
marvinjude approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@marvinjude marvinjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@wardpeet wardpeet merged commit b13ddff into master Mar 18, 2022
@wardpeet wardpeet deleted the fix/preact-alias branch March 18, 2022 09:24
@pieh pieh added this to To cherry-pick in V4 Release hotfixes via automation Mar 18, 2022
@gatsbybot gatsbybot mentioned this pull request Mar 18, 2022
Merged
gatsbybot pushed a commit that referenced this pull request Mar 18, 2022
@wardpeet @pieh
fix(gatsby-plugin-preact): fix preact alias (#35156)
07facec 
(cherry picked from commit b13ddff)
@pieh pieh moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Mar 18, 2022
pieh pushed a commit that referenced this pull request Mar 18, 2022
@ViCo0TeCH @wardpeet
fix(gatsby-plugin-preact): fix preact alias (#35156) (#35169)
0275fad 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh pieh moved this from Backport PR opened to Backported in V4 Release hotfixes Mar 18, 2022
@pieh pieh moved this from Backported to Published in V4 Release hotfixes Mar 18, 2022
@pieh
Copy link
Contributor

pieh commented Mar 18, 2022

Published in gatsby-plugin-preact@6.10.1

@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@joeawillis joeawillis mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@saurabharch saurabharch mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
Open
@monizb monizb mentioned this pull request Dec 1, 2023
Open
@wizbit wizbit mentioned this pull request Dec 2, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 2, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@marvinjude marvinjude marvinjude approved these changes

Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-preact: Can't resolve 'react/jsx-runtime' with @mui/material
4 participants
@wardpeet @LekoArts @pieh @marvinjude