Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): remove apis from ts,tsx #35183

Merged
merged 5 commits into from
Mar 21, 2022
Merged

fix(gatsby): remove apis from ts,tsx #35183

merged 5 commits into from
Mar 21, 2022

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 21, 2022 •
edited
Loading

Description

Not all instances of getServerData or config are removed, the rule only applies to js, mjs & jsx files. Not it also supports ts, TSX.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
imjoshin
imjoshin approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@imjoshin imjoshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method is clean, I like it 💪

@wardpeet
Copy link
Contributor Author

I just copied it from an already existing one 😂

@wardpeet wardpeet merged commit 8de18e7 into master Mar 21, 2022
@wardpeet wardpeet deleted the fix/modified-exports-ts branch March 21, 2022 14:53
@wardpeet wardpeet added this to To cherry-pick in V4 Release hotfixes via automation Mar 21, 2022
@gatsbybot gatsbybot mentioned this pull request Mar 22, 2022
Merged
pieh pushed a commit that referenced this pull request Mar 22, 2022
@wardpeet @pieh
fix(gatsby): remove apis from ts,tsx (#35183)
83881f2 
(cherry picked from commit 8de18e7)
@pieh pieh moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Mar 22, 2022
pieh pushed a commit that referenced this pull request Mar 22, 2022
@ViCo0TeCH @wardpeet
fix(gatsby): remove apis from ts,tsx (#35183) (#35198)
0b6067a 
(cherry picked from commit 8de18e7)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh pieh moved this from Backport PR opened to Backported in V4 Release hotfixes Mar 22, 2022
@pieh pieh moved this from Backported to Published in V4 Release hotfixes Mar 22, 2022
@pieh
Copy link
Contributor

pieh commented Mar 22, 2022

Published in gatsby@4.10.2

This was referenced Mar 29, 2022
Open
Open
Open
Open
Open
Open
Open
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
Open
@monizb monizb mentioned this pull request Dec 1, 2023
Open
@wizbit wizbit mentioned this pull request Dec 2, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 2, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoshin imjoshin imjoshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wardpeet @pieh @imjoshin