Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Improve get-config-file error handling #35776

Merged
merged 6 commits into from
May 31, 2022
Merged

fix(gatsby): Improve get-config-file error handling #35776

merged 6 commits into from
May 31, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented May 30, 2022 •
edited by LekoArts

Description

  • Add tests for get-config-file
  • Handle case where there is no compiled config in .cache/compiled/gatsby-config.js and a gatsby-config.ts file exists in the project root. We currently output the error message "Please rename 'gatsby-config.ts' to 'gatsby-config.js'", which is confusing

Documentation

N/A

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 30, 2022
@tyhopp tyhopp changed the title fix(gatsby): Add tests for get-config-file fix(gatsby): Improve get-config-file error handling May 30, 2022
@tyhopp tyhopp added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 30, 2022
@tyhopp tyhopp marked this pull request as draft May 30, 2022 08:54
@tyhopp tyhopp marked this pull request as ready for review May 31, 2022 05:00
@LekoArts
Copy link
Contributor

windows tests are failing on some path delimiter issue :)

@LekoArts LekoArts merged commit 160bbf0 into master May 31, 2022
@LekoArts LekoArts deleted the fix-gatsby-improve-get-config-file-error-handling branch May 31, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-config] ERROR #10124 Please rename "gatsby-config.ts" to "gatsby-config.js"
2 participants
@tyhopp @LekoArts