fix(gatsby-source-wordpress): bug patch for issue 35460

[tsdexter]

Description

Check the pluginOptions.type.MediaItem.exclude before fetching referenced media items during page updates

Documentation

Related Issues

Fixes #35460

[TylerBarnes]

Looks good! Thanks for this @tsdexter !

[tsdexter]

no problem @TylerBarnes ... happy to be able to contribute

ps. I noticed there are a few other places where fetchReferencedMediaItemsAndCreateNodes is called without any option checks... none of them affected my issue and I'm not fully aware of the context in which they're called so I didn't add any plug-in option checks around the ones unrelated to my specific issue.

[TylerBarnes]

Good to know, thanks for calling that out! Always open to a PR for those ;) but otherwise I'll make a note to remember to add those checks. Thanks again!

[tsdexter]

@TylerBarnes would it make sense to localize the check into the function? If so, I can do that and cleanup the other individual checks.

Something like:

export default async function fetchReferencedMediaItemsAndCreateNodes({
  referencedMediaItemNodeIds,
  mediaItemUrls,
}) {
  const state = store.getState()
  const queryInfo = state.remoteSchema.nodeQueries.mediaItems
  const { helpers, pluginOptions } = state.gatsbyApi

  if (pluginOptions.type.MediaItem.exclude) return []

  const { createContentDigest, actions } = helpers
  const { url } = pluginOptions
  const { typeInfo, settings, selectionSet, builtFragments } = queryInfo
...

[TylerBarnes]

Yeah, that seems reasonable 👍

[tsdexter]

@TylerBarnes #35827