Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-graphql): add dataLoaderOptions validation to gatsby-source-graphql #36112

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix(gatsby-source-graphql): add dataLoaderOptions validation to gatsby-source-graphql #36112

merged 1 commit into from
Aug 24, 2022

Conversation

that1matt
Copy link
Contributor

Description

gatsby-source-graphql throws warning when passing in dataLoaderOptions in gatsby-config.js.

warn Warning: there are unknown plugin options for "gatsby-source-graphql": dataLoaderOptions
Please open an issue at https://ghub.io/gatsby-source-graphql if you believe this option is valid.

Documentation

Grabbed initial types from dataLoaderOptions

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 12, 2022
@that1matt that1matt changed the title [gatsby-source-graphql] add dataLoaderOptions validation to gatsby-source-graphql [gatsby-source-graphql] fix: add dataLoaderOptions validation to gatsby-source-graphql Jul 12, 2022
@imjoshin imjoshin added topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 12, 2022
@that1matt that1matt dismissed a stale review via e8946bd August 11, 2022 19:56
@that1matt that1matt force-pushed the gatsby-source-grapqhl-dataloader-options branch from ad6e924 to e8946bd Compare August 11, 2022 19:56
@that1matt that1matt force-pushed the gatsby-source-grapqhl-dataloader-options branch from e8946bd to 7d99cc6 Compare August 24, 2022 17:48
@that1matt
Copy link
Contributor Author

@j0sh77 is there anything I need to do to help get this merged in?

@imjoshin
Copy link
Contributor

imjoshin commented Aug 24, 2022 •
edited
Loading

@j0sh77 is there anything I need to do to help get this merged in?

Sorry, this slipped through the cracks. Based off of https://github.com/graphql/dataloader#new-dataloaderbatchloadfn--options, this looks good to me. Thank you! 💜

Just gonna wait for the tests and I'll merge once those look good.

@imjoshin imjoshin changed the title [gatsby-source-graphql] fix: add dataLoaderOptions validation to gatsby-source-graphql fix(gatsby-source-graphql): add dataLoaderOptions validation to gatsby-source-graphql Aug 24, 2022
@imjoshin imjoshin merged commit b8c2072 into gatsbyjs:master Aug 24, 2022
This was referenced Nov 26, 2023
Open
Open
@joeawillis joeawillis mentioned this pull request Nov 26, 2023
Open
@wizbit wizbit mentioned this pull request Nov 26, 2023
Open
@joeawillis joeawillis mentioned this pull request Nov 26, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 26, 2023
Open
@wizbit wizbit mentioned this pull request Nov 26, 2023
Open
This was referenced Nov 26, 2023
Open
Open
Open
This was referenced Nov 26, 2023
Open
Open
@tonyg101 tonyg101 mentioned this pull request Nov 26, 2023
Open
@impactyogi impactyogi mentioned this pull request Nov 26, 2023
Open
@joeawillis joeawillis mentioned this pull request Nov 26, 2023
Open
This was referenced Nov 26, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 15, 2024
Open
@saurabharch saurabharch mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@monizb monizb mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
Open
This was referenced May 15, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 16, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoshin imjoshin imjoshin approved these changes

Assignees
No one assigned
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@that1matt @imjoshin