Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): fix --https option for develop #36248

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix(gatsby): fix --https option for develop #36248

merged 1 commit into from
Jul 27, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jul 27, 2022

Description

#35675 broke https option, this change restores it

Related Issues

Fixes #36241

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 27, 2022
Comment on lines -6 to +7
key: Buffer
cert: Buffer
key: string
cert: string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are passing ICert Object to child process, so this has to be serializable. Buffer can be serialized but but this was fastest way to fix as Strings are also supported.

Without this I was getting:

The "options.cert" property must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object

@pieh pieh added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 27, 2022
@pieh pieh merged commit abc65a6 into master Jul 27, 2022
@pieh pieh deleted the fix/develop/https branch July 27, 2022 12:00
@badaczewski
Copy link

Any idea when this will get a release? This is broken in 4.19.0, 4.19.1 and 4.19.2.

@jjang16
Copy link

jjang16 commented Aug 1, 2022

This issue is pretty urgent. Build is broken from 4.18 and below, and Dev is broken 4.19

@christopherrobinson
Copy link

christopherrobinson commented Aug 1, 2022

Can we get a release with this fix in? Currently hacking this in locally with patch-package

@LekoArts
Copy link
Contributor

LekoArts commented Aug 1, 2022

A minor release goes out every two weeks, so the next one is tomorrow.

@pieh
Copy link
Contributor Author

pieh commented Aug 1, 2022

This was released in gatsby@next, so you can use that temporarily (it will be released in gatsby@latest stable tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--https doesn't work since Gatsby 4.19.0
5 participants