feat(gatsby): Normalize module keys between webpack plugin and loader #36644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: core
tyhopp
force-pushed
the
feat/partal-hydration-normalized-module-keys
branch
from
286566b
to
4913bba
Compare
LekoArts
reviewed
Sep 21, 2022
tyhopp
force-pushed
the
feat/partal-hydration-normalized-module-keys
branch
from
a540d02
to
cf45642
Compare
LekoArts
approved these changes
Sep 23, 2022
LekoArts
previously requested changes
Sep 23, 2022
There was a problem hiding this comment.
Oh, windows tests actually caught something:
Error: expect(received).toMatchSnapshot()
Snapshot name: `should normalize bare module imports from node_modules 1`
Snapshot: "file://node_modules/package-name"
Received: "file://Users/username/project/node_modules/package-name"
tyhopp
force-pushed
the
feat/partal-hydration-normalized-module-keys
branch
from
d8f01e6
to
c1eb721
Compare
Fixed in 8f11802 |
pieh
approved these changes
Sep 26, 2022
| projectRoot | ||
| ) | ||
|
|
||
| expect(normalizedModuleKey).toMatchSnapshot() |
There was a problem hiding this comment.
NIT: I'd suggest using .toMatchInlineSnapshot() here given that output is not large, and that will collocate "expected" value to be here, making it easier to see what assertion is actually being done here (regular snapshot requires looking stuff up in .snap files etc).
Not big deal, just my preference for this kind of things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalize module keys between the partial hydration webpack loader and plugin.
Previously the actual resource path was used, which caused problems because the different modules can be loaded in the loader and plugin based off of what is declared in
package.json.Documentation
N/A
Related Issues
[sc-55773]