fix(gatsby): Use hex hash for CSS modules #36701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: webpack/babel
pieh
approved these changes
Sep 27, 2022
LekoArts
pushed a commit
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit 0683ae8)
LekoArts
pushed a commit
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use a base64 hash for CSS modules, and the (non-variant) base64 lexicon contains the the plus character (
+), which is the adjacent-sibling combinator (.a + .b) in CSS.Switch to
hexinstead. Triedbase64url(introduced in Node14.18.0) but it doesn't work (maybe webpack docs are incorrect, will look into this).Paper trail:
css-loaderdocs recommendbase64- https://webpack.js.org/loaders/css-loader/#localidentnamewebpackcoreoutput.hashDigestdocs mentionbase64- https://webpack.js.org/configuration/output/#outputhashdigest and that it supports all other encodings Node supportsDocumentation
N/A
Related Issues
Fixes #36673