chore: Slight update to CircleCI config #36823
Conversation
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
changed the title
| @@ -523,14 +523,15 @@ jobs: | |||
| yarn | |||
| - run: | |||
| name: Run tests | |||
| command: yarn jest --ci --runInBand ((yarn jest --listTests) | Foreach-Object {$_ -replace '.*\\packages', 'packages'} | Foreach-Object {$_ -replace '\\', '/'} | circleci tests split --split-by=timings) | |||
| command: yarn jest --ci --runInBand ((yarn jest --listTests) | Foreach-Object {$_ -replace '.*\\packages', 'packages'} | Foreach-Object {$_ -replace '\\', '/'} | circleci tests split) | |||
There was a problem hiding this comment.
Since we don't store the results of the timings from previous runs it always runs in the default split mode anyways
LekoArts
added
the
topic: automation
| @@ -1,6 +1,5 @@ | |||
| orbs: | |||
| win: circleci/windows@2.4.0 | |||
| slack: circleci/slack@3.4.1 | |||
There was a problem hiding this comment.
We don't use that anymore
| @@ -99,6 +98,7 @@ aliases: | |||
| GENERATE_JEST_REPORT: "true" | |||
| JEST_JUNIT_OUTPUT_DIR: ./test-results/jest-node/ | |||
| JEST_JUNIT_OUTPUT_NAME: results.xml | |||
| JEST_JUNIT_REPORT_TEST_SUITE_ERRORS: "true" | |||
There was a problem hiding this comment.
Reports test suites that failed to execute altogether as error. Note: since the suite name cannot be determined from files that fail to load, it will default to file path.
Doesn't hurt to enable that I guess
There was a problem hiding this comment.
Were you able to see improved reporting with JEST_JUNIT_REPORT_TEST_SUITE_ERRORS enabled? I looked at the errors in CI for this PR but can't tell if it's different
There was a problem hiding this comment.
No, didn't seem to make a difference really
Description
This PR started as a try to fix some Jest quirks in CI but couldn't really get that working. I've also didn't really see this anymore in newer tests. So maybe it's intermittent or fixed itself.
Nevertheless, the updates here are good anyways to be merged.