Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Slices <> partial hydration interop #36960

Merged
merged 8 commits into from
Nov 4, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Nov 4, 2022

Description

Make partial hydration and slices features work simultaneously.

Documentation

Check if we have it mentioned anywhere that slices is not enabled when partial hydration is and remove it

Related Issues

[sc-57892]

@tyhopp tyhopp added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Nov 4, 2022
@tyhopp tyhopp added this to the Gatsby 5 milestone Nov 4, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2022
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2022
@tyhopp tyhopp marked this pull request as ready for review November 4, 2022 08:40
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you for handling loader mess :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants