-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-filesystem): Expose usePolling option #36975
base: master
Are you sure you want to change the base?
feat(gatsby-source-filesystem): Expose usePolling option #36975
Conversation
The plugin README needs to be updated -- If you have any guidance on how you want to incorporate it, I can take a shot at it. |
Is the
|
The https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-source-filesystem#options section could use a little revamp.
|
I could not get it to work. Both from the command line and explicitly in package.json, using |
In scenarios where the use of file system polling is necessary (network file systems, hard links, etc)
75fb1b1
to
47db9e9
Compare
It works for me I'd also be surprised to not have https://github.com/paulmillr/chokidar/blob/0f163b89f3ae76607900aa48fec9fa3fdefd7ca1/index.js#L341 working - so with this in mind I'm actually inclined to not add the option at all. Better to not give people the option (less footguns). We should update the readme tho (which e.g. could point out the env var) |
I found the issue: When you use the If you just use the environment variable, both It doesn't seem like setting I'm not sure what the best course of action here is since you need to understand the behavior of an internal library to understand what to do (not to mention the wierd macOS only side effect behavior). I could try submitting a PR to chokidar to expose a |
Yeah, I fear this is out of our hands then. Best course of action then is to open an issue with them to fix this behavior. Either by introducing a new environment variable or moving the code around so that |
Description
In scenarios where the use of file system polling is necessary (network file systems, hard links, etc).
Relevant chokidar option description here -- https://github.com/paulmillr/chokidar#performance
Documentation
Related Issues
Fixes #36877