Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Repository Cleanup #37035

Merged
merged 10 commits into from
Nov 15, 2022
Merged

chore: Repository Cleanup #37035

merged 10 commits into from
Nov 15, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Nov 14, 2022

Description

For the PR #37009 I wondered why renovate is changing the lockfile version from v2 to v1. It's using an older npm version it seems. So let's try adding a .nvmrc file.

But I figured cleaning up the monorepo a bit won't hurt so here are the changes in addition to that:

  • Remove svgo pipeline since we now rarely add .svg files (this was relevant for the website)
  • Remove remark pipeline since we don't cover/care about this at all in our PR process
  • Remove old scripts that are no longer used
  • Remove plop and plop-templates since we didn't use this for any new packages at all
  • Remove i18n scripts
  • Random updates like removing old comments in dotfiles, removing deprecated-packages in dotfiles

Related Issues

[ch58168]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2022
@LekoArts LekoArts marked this pull request as ready for review November 14, 2022 10:33
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 14, 2022
Copy link
Contributor

@tyhopp tyhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will approve but not merge since some of this stuff is before my time and might benefit from another pair of eyes

@LekoArts LekoArts merged commit 0fb0390 into master Nov 15, 2022
@LekoArts LekoArts deleted the repo-cleanup branch November 15, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants