feat(gatsby-source-wordpress): MediaItem.excludeFieldNames / auto exclude interface types that have no fields (#37062) #37085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lude interface types that have no fields (#37062) * allow MediaItem type to use excludeFieldNames option * make sure cached media item nodes always return the MediaItem node, not File nodes if those are cached * use get type settings helper instead of accessing settings on options * auto exclude interface types that have no fields due to an implementing type excluding all of it's fields * this should've been excluded before! Fixed now * update comment * use Map for caching instead of object properties * exclude MediaItem.template field in tests * remove debug code (cherry picked from commit 0501ed3)
gatsbot
bot
added
the
status: triage needed
LekoArts
changed the title
LekoArts
removed
the
status: triage needed
This was referenced Jan 12, 2023
Open
This was referenced Jan 12, 2023
This was referenced Apr 25, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #37062 to the 4.24 release branch
(cherry picked from commit
0501ed3)