Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Add documentSearchPaths option to graphqlTypegen #37120

Merged
merged 5 commits into from
Dec 1, 2022
Merged

feat(gatsby): Add documentSearchPaths option to graphqlTypegen #37120

merged 5 commits into from
Dec 1, 2022

Conversation

openscript
Copy link
Contributor

Description

This PR makes the GraphQL codegen document search paths configurable from the Gatsby configuration file.

Documentation

Integrated into gatsby-config.md

Related Issues

Fixes #35853
Related to #35966
Related to #36157

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 29, 2022
@openscript openscript changed the title feat: make graphql codegen document search paths configurable feat(gatsby): make graphql codegen document search paths configurable Nov 29, 2022
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 30, 2022
@LekoArts
Copy link
Contributor

LekoArts commented Nov 30, 2022 •
edited
Loading

Hey, thanks for the PR! Can you also update the docs/docs/how-to/local-development/graphql-typegen.md documentation like I did in my PR #35966 ? Thanks!

It should be a bulletpoint under the Configuration the gatsby-config option heading and make the typesOutputPath sentence also a bulletpoint

@LekoArts LekoArts changed the title feat(gatsby): make graphql codegen document search paths configurable feat(gatsby): Add documentSearchPaths option to graphqlTypegen Dec 1, 2022
LekoArts
LekoArts approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 712ff6b into gatsbyjs:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL Typegen only picking up graphql tag usage from gatsby-node.ts
2 participants
@openscript @LekoArts