fix(gatsby): Improve readability of page data / long running query warnings #37220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to #36876 Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Daniel Lew <danielshlomolew@gmail.com>
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
LekoArts
commented
Dec 8, 2022
| if (!_.isEmpty(context)) { | ||
| messageParts.push(`Context: ${JSON.stringify(context, null, 4)}`) | ||
| } | ||
| if (queryJob.queryType === `page`) { |
There was a problem hiding this comment.
The TS type said that isPage is not actually a thing on that object
There was a problem hiding this comment.
Ah yes, isPage was changed to queryType when I added slice queries as then we had 3 options for queries (page, static and slice) that no longer would work with single boolean and decided type is better than adding isSlice or isStatic on top of isPage
There was a problem hiding this comment.
So that means that since v5 we were actually not showing path or context on those long running queries I guess?
There was a problem hiding this comment.
I seems like that 😆
tyhopp
approved these changes
Dec 9, 2022
marvinjude
pushed a commit
that referenced
this pull request
Dec 9, 2022
…rnings (#37220) * show better page data information * clean up longrunning queries Alternative to #36876 Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Daniel Lew <danielshlomolew@gmail.com> Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Daniel Lew <danielshlomolew@gmail.com> (cherry picked from commit 031a08f)
marvinjude
pushed a commit
that referenced
this pull request
Dec 9, 2022
…rnings (#37220) (#37229) * show better page data information * clean up longrunning queries Alternative to #36876 Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Daniel Lew <danielshlomolew@gmail.com> Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Daniel Lew <danielshlomolew@gmail.com> (cherry picked from commit 031a08f) Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to improve the readability of errors while HTML rendering and the warnings about long running queries. It's improved by removing verbosity that isn't that all too helpful.
Related Issues
[ch59128]