Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(how-to): remove unecessary decomposition #37341

Merged
merged 1 commit into from
Jan 3, 2023
Merged

docs(how-to): remove unecessary decomposition #37341

merged 1 commit into from
Jan 3, 2023

Conversation

openscript
Copy link
Contributor

Description

getNodesByType is decomposed from the actions, but it's never used, so I removed it.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 28, 2022
Copy link
Contributor

@tyhopp tyhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The final example does use getNodesByType in

getNodesByType(POST_NODE_TYPE).forEach(node => touchNode(node))
getNodesByType(AUTHOR_NODE_TYPE).forEach(node => touchNode(node))
but I agree that it makes sense to remove it from the snippets in the doc since it's not used there.

@tyhopp tyhopp added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2023
@tyhopp tyhopp merged commit bcd3bcc into gatsbyjs:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants