fix(gatsby-source-shopify): Use id as cacheKey for base64 image
#37397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
2 tasks
LekoArts
added
topic: source-shopify
LekoArts
changed the title
id as cacheKey for base64 image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with gatsby-source-shopify. Specifically, passing the placeholder: 'BLURRED' option to a ShopifyMediaImage GraphQL query doesn't work - gatsby source shopify returns an error, "TypeError: Cannot read properties of undefined (reading 'contentDigest')".
The change is simple, switch out the 'contentDigest' parameter for an 'imageId' parameter. Content digest was 'image.internal.contentDigest' - imageId is 'image.id'. This parameter is a unique string used as a cacheKey for the image.
Documentation
The gatsby source shopify docs don't go into this. It's a tiny change.
Related Issues
Fixes #35930