Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-drupal): await async handleDeletedNode #37435

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix(gatsby-source-drupal): await async handleDeletedNode #37435

merged 1 commit into from
Jan 10, 2023

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Jan 10, 2023 •
edited
Loading

This async function isn't being awaited. I have a theory this is causing a problem for large sites (or maybe for all sites randomly) but I haven't verified that. This should be awaited either way though so should be good to merge.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 10, 2023
@TylerBarnes TylerBarnes added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 10, 2023
@TylerBarnes TylerBarnes added this to To cherry-pick in V4 Release hotfixes via automation Jan 10, 2023
@TylerBarnes TylerBarnes added this to To cherry-pick in V5 Release hotfixes via automation Jan 10, 2023
@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 10, 2023
@TylerBarnes TylerBarnes merged commit e575a0a into master Jan 10, 2023
@TylerBarnes TylerBarnes deleted the fix/delete-race-condition branch January 10, 2023 23:45
@gatsbybot gatsbybot mentioned this pull request Jan 13, 2023
Merged
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@TylerBarnes @tyhopp
fix(gatsby-source-drupal): await async handleDeletedNode (#37435)
cc842b5 
await async handleDeletedNode

(cherry picked from commit e575a0a)
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Jan 13, 2023
@gatsbybot gatsbybot mentioned this pull request Jan 13, 2023
Merged
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@TylerBarnes @tyhopp
fix(gatsby-source-drupal): await async handleDeletedNode (#37435)
8720dff 
await async handleDeletedNode

(cherry picked from commit e575a0a)
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Jan 13, 2023
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@ViCo0TeCH @TylerBarnes
fix(gatsby-source-drupal): await async handleDeletedNode (#37435) (#3…
19d3861 
…7458)

await async handleDeletedNode

(cherry picked from commit e575a0a)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@ViCo0TeCH @TylerBarnes
fix(gatsby-source-drupal): await async handleDeletedNode (#37435) (#3…
1761903 
…7461)

await async handleDeletedNode

(cherry picked from commit e575a0a)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
@tyhopp tyhopp moved this from Backport PR opened to Backported in V4 Release hotfixes Jan 13, 2023
@tyhopp tyhopp moved this from Backport PR opened to Backported in V5 Release hotfixes Jan 13, 2023
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Jan 13, 2023
@pieh
Copy link
Contributor

pieh commented Jan 13, 2023

Published in:

  • gatsby-source-drupal@6.4.1
  • gatsby-source-drupal@5.26.1

@pieh pieh moved this from Backported to Published in V4 Release hotfixes Jan 13, 2023
@saurabharch saurabharch mentioned this pull request Jan 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Apr 18, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Apr 18, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
This was referenced May 26, 2023
Open
Open
This was referenced May 26, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
@Rutam21 Rutam21 mentioned this pull request May 26, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
This was referenced May 26, 2023
Open
Open
@monizb monizb mentioned this pull request May 26, 2023
Open
This was referenced May 27, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 30, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 30, 2023
Open
This was referenced May 31, 2023
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@kathmbeck kathmbeck kathmbeck approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-drupal Related to Gatsby's integration with Drupal
Projects
V4 Release hotfixes
Published
V5 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TylerBarnes @pieh @KyleAMathews @kathmbeck