Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Use correct settings for yaml-loader #37454

Merged
merged 2 commits into from Jan 12, 2023
Merged

fix(gatsby): Use correct settings for yaml-loader #37454

merged 2 commits into from Jan 12, 2023

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 12, 2023 •
edited

Description

In #37401 we bumped yaml-loader but missed the change eemeli/yaml-loader#27. This PR fixes #37453 by using the correct settings.

Related Issues

Fixes #37453
[ch60027]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 12, 2023
@LekoArts LekoArts added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 12, 2023
@LekoArts LekoArts added this to To cherry-pick in V5 Release hotfixes via automation Jan 12, 2023
@marvinjude marvinjude merged commit 3ef4f44 into master Jan 12, 2023
@marvinjude marvinjude deleted the fix-yaml-loader branch January 12, 2023 15:49
@tyhopp tyhopp added this to To cherry-pick in V4 Release hotfixes via automation Jan 13, 2023
@gatsbybot gatsbybot mentioned this pull request Jan 13, 2023
Merged
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@LekoArts @tyhopp
fix(gatsby): Use correct settings for yaml-loader (#37454)
3a72547 
* fix

* add e2e test

(cherry picked from commit 3ef4f44)
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Jan 13, 2023
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@LekoArts @tyhopp
fix(gatsby): Use correct settings for yaml-loader (#37454)
3591cb2 
* fix

* add e2e test

(cherry picked from commit 3ef4f44)
@gatsbybot gatsbybot mentioned this pull request Jan 13, 2023
Merged
@tyhopp tyhopp moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Jan 13, 2023
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@ViCo0TeCH @LekoArts
fix(gatsby): Use correct settings for yaml-loader (#37454) (#37463)
8109b9b 
* fix

* add e2e test

(cherry picked from commit 3ef4f44)

Co-authored-by: Lennart <lekoarts@gmail.com>
tyhopp pushed a commit that referenced this pull request Jan 13, 2023
@ViCo0TeCH @LekoArts
fix(gatsby): Use correct settings for yaml-loader (#37454) (#37460)
b229e7b 
* fix

* add e2e test

(cherry picked from commit 3ef4f44)

Co-authored-by: Lennart <lekoarts@gmail.com>
@tyhopp tyhopp moved this from Backport PR opened to Backported in V4 Release hotfixes Jan 13, 2023
@tyhopp tyhopp moved this from Backport PR opened to Backported in V5 Release hotfixes Jan 13, 2023
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Jan 13, 2023
@pieh pieh moved this from Backported to Published in V4 Release hotfixes Jan 13, 2023
@pieh
Copy link
Contributor

pieh commented Jan 13, 2023

Published in:

  • gatsby@4.25.3
  • gatsby@5.4.1

@saurabharch saurabharch mentioned this pull request Jan 19, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 24, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jan 24, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 24, 2023
Open
This was referenced Jan 24, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
This was referenced May 26, 2023
Open
Open
This was referenced May 26, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
@Rutam21 Rutam21 mentioned this pull request May 26, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 26, 2023
Open
This was referenced May 26, 2023
Open
Open
@monizb monizb mentioned this pull request May 26, 2023
Open
This was referenced May 27, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 30, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 30, 2023
Open
This was referenced May 31, 2023
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinjude marvinjude marvinjude approved these changes

Assignees
No one assigned
Labels
topic: webpack/babel Webpack or babel
Projects
V4 Release hotfixes
Published
V5 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatsby 5.4.0 fails to import yaml files
3 participants
@LekoArts @pieh @marvinjude