Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): support slices in DEV_SSR #37542

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jan 27, 2023

Description

Add missing support for slices when using DEV_SSR flag + tests in integration-tests/ssr confirming it works.
First commit just with tests fails, second passes.

Documentation

Related Issues

Fixes #37537
[ch-60639]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 27, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 27, 2023
@pieh pieh changed the title fix(dev-ssr): support slices fix(gatsby): support slices in DEV_SSR Jan 27, 2023
@pieh pieh marked this pull request as ready for review January 27, 2023 18:50
@tyhopp tyhopp merged commit 58b0625 into master Jan 30, 2023
@tyhopp tyhopp deleted the fix/support-slices-in-dev-ssr branch January 30, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to server render when use Slice API
2 participants