Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-shopify): use gatsby node id to enable relationships #37775

Merged
merged 4 commits into from
Mar 25, 2023
Merged

feat(gatsby-source-shopify): use gatsby node id to enable relationships #37775

merged 4 commits into from
Mar 25, 2023

Conversation

wardpeet
Copy link
Contributor

Description

Move to Gatsby Node Id instead of shopify ids to make relationships. I've added _fields so we don't introduce a possible breaking change for users using onCreateNode

Documentation

Tests

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 22, 2023
@wardpeet wardpeet added this to To cherry-pick in V5 Release hotfixes via automation Mar 22, 2023
@LekoArts LekoArts added topic: source-shopify Related to the gatsby-source-shopify plugin topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 22, 2023
@wardpeet wardpeet merged commit a2c3fa3 into master Mar 25, 2023
@wardpeet wardpeet deleted the fix/content-cloud-shopify-relationships branch March 25, 2023 22:41
@gatsbybot gatsbybot mentioned this pull request Mar 27, 2023
Merged
pieh pushed a commit that referenced this pull request Mar 27, 2023
@wardpeet @pieh
feat(gatsby-source-shopify): use gatsby node id to enable relationshi…
9eea01c 
…ps (#37775)

* feat(gatsby-source-shopify): use gatsby node id to enable relationships

* remove console.Log

* Enable jest

* fix tests

(cherry picked from commit a2c3fa3)
@pieh pieh moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Mar 27, 2023
@pieh pieh moved this from Backport PR opened to Backported in V5 Release hotfixes Mar 27, 2023
pieh pushed a commit that referenced this pull request Mar 27, 2023
@ViCo0TeCH @wardpeet
feat(gatsby-source-shopify): use gatsby node id to enable relationshi…
0f838b2 
…ps (#37775) (#37786)

* feat(gatsby-source-shopify): use gatsby node id to enable relationships

* remove console.Log

* Enable jest

* fix tests

(cherry picked from commit a2c3fa3)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Mar 27, 2023
@0xSebin 0xSebin mentioned this pull request Apr 18, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-shopify Related to the gatsby-source-shopify plugin
Projects
V5 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wardpeet @LekoArts