feat(gatsby-source-contentful): add support for setting type prefix #37981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
commented
Apr 27, 2023
packages/gatsby-source-contentful/src/__tests__/__snapshots__/gatsby-node.js.snap
Outdated
Show resolved
Hide resolved
ascorbic
commented
Apr 27, 2023
ascorbic
commented
Apr 27, 2023
| name: `ContentfulAsset`, | ||
| }) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Checking both that it created the types with the prefix, but also that it doesn't create types with the default
ascorbic
commented
Apr 27, 2023
ascorbic
commented
Apr 27, 2023
Comment on lines
-336
to
+339
| currentSyncData?.entries.length + | ||
| currentSyncData?.assets.length + | ||
| currentSyncData?.deletedEntries.length + | ||
| currentSyncData?.deletedAssets.length === | ||
| 0 | ||
| !currentSyncData?.entries.length && | ||
| !currentSyncData?.assets.length && | ||
| !currentSyncData?.deletedEntries.length && | ||
| !currentSyncData?.deletedAssets.length |
There was a problem hiding this comment.
Thsi was giving TS errors, because it was trying to perform arithmetic when the value is possibly null (thanks to the optional chain)
ascorbic
commented
Apr 27, 2023
Comment on lines
-8
to
13
| const typePrefix = `Contentful` | ||
| export const makeTypeName = type => | ||
| /** | ||
| * @param {string} type | ||
| * @param {string} typePrefix | ||
| */ | ||
| export const makeTypeName = (type, typePrefix) => | ||
| _.upperFirst(_.camelCase(`${typePrefix} ${type}`)) |
There was a problem hiding this comment.
typePrefix was already a thing, it was just previously hard-coded
ascorbic
commented
Apr 27, 2023
| _.upperFirst(_.camelCase(`${typePrefix} ${type}`)) | ||
| export const assetTypeName = makeTypeName(`Asset`) |
There was a problem hiding this comment.
Can't hard-code this anymore
LekoArts
added
topic: source-contentful
TylerBarnes
reviewed
Apr 27, 2023
TylerBarnes
approved these changes
Apr 28, 2023
|
Another feature of the rewrite finding itself in the old version :D Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
typePrefixtogatsby-source-contentful. This is prefixed to the names of the generated node types. It defaults toContentful, which is the current value used.Documentation
Added to readme
Tests
Added unit tests.
Related Issues
Fixes https://github.com/gatsby-inc/netlify-valhalla/issues/178