Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-plugin-feed): Remove @hapi/joi dependency #38205

Merged
merged 2 commits into from Jun 12, 2023
Merged

chore(gatsby-plugin-feed): Remove @hapi/joi dependency #38205

merged 2 commits into from Jun 12, 2023

Conversation

naveen521kk
Copy link
Contributor

@naveen521kk naveen521kk commented Jun 7, 2023 •
edited

Description

This should remove the following warning from npm: (when depending on gatsby-plugin-feed)

npm WARN deprecated @hapi/joi@15.1.1: Switch to 'npm install joi'

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 7, 2023
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 12, 2023
LekoArts
LekoArts approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

The dependency is actually not used so we can remove it entirely

@LekoArts LekoArts merged commit 52a0023 into gatsbyjs:master Jun 12, 2023
28 of 31 checks passed
@LekoArts LekoArts changed the title chore(gatsby-plugin-feed): depend on joi instead of @hapi/joi chore(gatsby-plugin-feed): Remove @hapi/joi dependency Jun 12, 2023
@naveen521kk naveen521kk deleted the joi-dep branch June 12, 2023 09:02
@X-oss-byte X-oss-byte mentioned this pull request Jul 14, 2023
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 12, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Nov 27, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 27, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 19, 2023
Open
@monizb monizb mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naveen521kk @LekoArts