fix(gatsby): don't break builds when using features unsupported by adapter #38520

pieh · 2023-09-05T09:55:12Z

Description

With release of adapters we introduced a way for adapters to report back if they support handling of pathPrefix and trailingSlash options. In that release we made gatsby break builds if user options were unsupported by adapter as it did make sense to not allow potentially faulty deploys.

However because this wasn't major version bump it can be deemed as breaking change (especially if previously used deployment plugin didn't hard break on their own), so this change stops build failures and instead just prints a warning.

Users might be able to add their own support in some cases (in particular path prefix could be supported on Netlify with https://answers.netlify.com/t/deploy-gatsby-site-to-netlify-with-prefix-paths/1267/6 at least for static assets, but that wouldn't work for DSG/SSR tho, so it's also not full support), so this change unblocks thoes cases.

Documentation

Tests

Related Issues

Fixes: https://github.com/netlify/pillar-support/issues/720

…apter

MarcL

Thanks for the quick fix.

…apter (#38520) (cherry picked from commit 6674ad6)

…apter (#38520) (#38521) (cherry picked from commit 6674ad6) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

fix(gatsby): don't break builds when using features unsupported by ad…

1aaa857

…apter

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 5, 2023

pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 5, 2023

pieh added this to To cherry-pick in V5 Release hotfixes via automation Sep 5, 2023

MarcL approved these changes Sep 5, 2023

View reviewed changes

pieh merged commit 6674ad6 into master Sep 5, 2023
33 checks passed

pieh deleted the dont-fail-the-build-if-adapter-doesnt-support-a-feature branch September 5, 2023 11:14

gatsbybot mentioned this pull request Sep 5, 2023

fix(gatsby): don't break builds when using features unsupported by adapter (#38520) #38521

Merged

pieh added a commit that referenced this pull request Sep 5, 2023

fix(gatsby): don't break builds when using features unsupported by ad…

1a2afe9

…apter (#38520) (cherry picked from commit 6674ad6)

pieh moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Sep 5, 2023

gatsbybot pushed a commit that referenced this pull request Sep 5, 2023

fix(gatsby): don't break builds when using features unsupported by ad…

232ec13

…apter (#38520) (#38521) (cherry picked from commit 6674ad6) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

techfg mentioned this pull request Sep 12, 2023

Gatsby Adapters causes regressions & issues with headers & redirects for NETLIFY builds on >=5.12.0 #38542

Open

2 tasks

pieh moved this from Backport PR opened to Backported in V5 Release hotfixes Sep 20, 2023

pieh moved this from Backported to Published in V5 Release hotfixes Sep 26, 2023

X-oss-byte mentioned this pull request Dec 29, 2023

[Snyk] Upgrade: gatsby, gatsby-plugin-manifest, gatsby-plugin-sharp, gatsby-source-wordpress, gatsby-transformer-sharp X-oss-byte/gatsby-1#352

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gatsby): don't break builds when using features unsupported by adapter #38520

fix(gatsby): don't break builds when using features unsupported by adapter #38520

pieh commented Sep 5, 2023 •

edited by MarcL

MarcL left a comment

fix(gatsby): don't break builds when using features unsupported by adapter #38520

fix(gatsby): don't break builds when using features unsupported by adapter #38520

Conversation

pieh commented Sep 5, 2023 • edited by MarcL

Description

Documentation

Tests

Related Issues

MarcL left a comment

Choose a reason for hiding this comment

pieh commented Sep 5, 2023 •

edited by MarcL