fix(gatsby-adapter-netlify): handle cases with large cached _redirects and/or _headers files #38559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
…s and/or _headers filestest(gatsby-adapter-netlify): add unit tests for entries injection
pieh
force-pushed
the
fix/netlify-adapter-inject-max-call-stack
branch
from
22e3d89
to
d74e7af
Compare
ascorbic
approved these changes
Sep 19, 2023
pieh
added a commit
that referenced
this pull request
Sep 19, 2023
…s and/or _headers files (#38559) * test(gatsby-adapter-netlify): add unit tests for entries injection * fix(gatsby-adapter-netlify): handle cases with large cached _redirects and/or _headers filestest(gatsby-adapter-netlify): add unit tests for entries injection * Update route-handler.ts (cherry picked from commit db41d13)
gatsbybot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…s and/or _headers files (#38559) (#38564) * test(gatsby-adapter-netlify): add unit tests for entries injection * fix(gatsby-adapter-netlify): handle cases with large cached _redirects and/or _headers filestest(gatsby-adapter-netlify): add unit tests for entries injection * Update route-handler.ts (cherry picked from commit db41d13) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
This was referenced Oct 18, 2023
This was referenced Oct 27, 2023
This was referenced Dec 6, 2023
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation can throw with
kind of errors. This will replace implementation and add unit tests to catch regressions in the future.
First commit just add a unit test suite + do minor refactors to module to make it easier to test (tests will fail showcasing current problem)
Second commit will change implementation and get tests to pass (proving the fix)
Documentation
Tests
Related Issues