Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-wordpress): only diff wpgraphql schema if the user opts in #38856

Merged
merged 2 commits into from
Feb 20, 2024
Merged

fix(gatsby-source-wordpress): only diff wpgraphql schema if the user opts in #38856

merged 2 commits into from
Feb 20, 2024

Conversation

TylerBarnes
Copy link
Contributor

Schema diffing was added by default to help catch issues with how the local WP schema is generated. In 99% of cases this is not helpful, so it was a mistake to make this the default behaviour.
This is only useful as a diagnostic tool when investigating a bug

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 17, 2024
@TylerBarnes TylerBarnes mentioned this pull request Feb 17, 2024
Closed
2 tasks
@pieh pieh added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 20, 2024
pieh
pieh previously approved these changes Feb 20, 2024
View reviewed changes
@pieh pieh merged commit 5bd4c25 into master Feb 20, 2024
33 of 34 checks passed
@pieh pieh deleted the fix/local-generated-typenames branch February 20, 2024 15:10
@pieh pieh added this to To cherry-pick in V5 Release hotfixes via automation Feb 20, 2024
pieh pushed a commit that referenced this pull request Feb 20, 2024
@TylerBarnes @pieh
fix(gatsby-source-wordpress): only diff wpgraphql schema if the user …
70b5696 
…opts in (#38856)

* only diff wpgraphql schema if the user opts in

* Update config.yml

---------

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 5bd4c25)
@gatsbybot gatsbybot mentioned this pull request Feb 20, 2024
Merged
@pieh pieh moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Feb 20, 2024
pieh pushed a commit that referenced this pull request Feb 21, 2024
@gatsbybot @TylerBarnes
fix(gatsby-source-wordpress): only diff wpgraphql schema if the user …
85f6c90 
…opts in (#38856) (#38860)

* only diff wpgraphql schema if the user opts in

* Update config.yml

---------

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 5bd4c25)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
@pieh pieh moved this from Backport PR opened to Backported in V5 Release hotfixes Feb 23, 2024
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Feb 23, 2024
@Rutam21 Rutam21 mentioned this pull request Feb 24, 2024
Open
This was referenced Feb 24, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Mar 15, 2024
Open
This was referenced May 1, 2024
Open
Open
Open
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 7, 2024
Open
This was referenced May 7, 2024
Open
Open
@monizb monizb mentioned this pull request May 8, 2024
Open
This was referenced May 9, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 16, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@DanielSLew DanielSLew Awaiting requested review from DanielSLew

Assignees
No one assigned
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
V5 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TylerBarnes @pieh