Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #569 Add port process conflict resolution and Chalk #579

Merged
merged 6 commits into from Nov 28, 2016

Conversation

vinnymac
Copy link
Contributor

I tested this out, it seems to work great, but I had to add someone else's repo as a dependency because the getProcessForPort method hasn't been pushed to the officially available react-dev-utils package on npm.

I also added some chalk here and there.

If you want me to change the wording or add the dependency a different way let me know 👍

@KyleAMathews
Copy link
Contributor

Awesome!

Could you add some screenshots?

Since this isn't much code — how about you just copy/paste the necessary code into Gatsby for now and then in a follow-up PR we use react-dev-utils once the function is published?

@vinnymac
Copy link
Contributor Author

vinnymac commented Nov 28, 2016

Okay I'll bring it over from react-dev-utils then. I'll see if I can get any good screenshots as well👍

@vinnymac
Copy link
Contributor Author

I brought the source in and fixed the lint issues that came with it. I also made the formatting look prettier. Here are some screenshots of the changes. Would you like me to put them somewhere?

screen shot 2016-11-28 at 4 39 48 pm

screen shot 2016-11-28 at 4 42 05 pm

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Nov 28, 2016

Nah — just wanted screenshots to document here the changes you were making. Looks great. Once the tests finish running, I'll merge the changes and make a quick release.

Thanks! This is a really nice little UX improvement.

@KyleAMathews KyleAMathews merged commit 946b9ec into gatsbyjs:master Nov 28, 2016
@vinnymac vinnymac deleted the port branch November 28, 2016 22:00
@KyleAMathews
Copy link
Contributor

@jlengstorf
Copy link
Contributor

Hiya @vinnymac! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants