Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat integers longer than 32 bit as floats. #6082

Merged
merged 4 commits into from
Jun 25, 2018
Merged

Treat integers longer than 32 bit as floats. #6082

merged 4 commits into from
Jun 25, 2018

Conversation

MichaelZoerner
Copy link
Contributor

The GraphQL specs limit the Integer type size to 32 bits. To be compliant, larger ints have to be treated as floats to prevent errors in query results.

fixes #6069

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 22, 2018

Deploy preview for gatsbygram ready!

Built with commit 342d17f

https://deploy-preview-6082--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 22, 2018

Deploy preview for using-drupal ready!

Built with commit 342d17f

https://deploy-preview-6082--using-drupal.netlify.com

@pieh
Copy link
Contributor

pieh commented Jun 22, 2018

Looking good, could you cover this in tests?

@MichaelZoerner
Copy link
Contributor Author

Yes, I hope it is better now.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @MichaelZoerner

@m-allanson m-allanson merged commit e117179 into gatsbyjs:master Jun 25, 2018
@MichaelZoerner MichaelZoerner deleted the topics/fix-int32 branch June 25, 2018 18:17
@jlengstorf
Copy link
Contributor

Hiya @MichaelZoerner! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ints > 32 bit are incorrectly inferred to GraphQLInt instead of GraphQLFloat
5 participants