Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 DOC: Non-conflict key mapping #8455

Merged
merged 2 commits into from
Sep 24, 2018
Merged

📖 DOC: Non-conflict key mapping #8455

merged 2 commits into from
Sep 24, 2018

Conversation

ahmadawais
Copy link
Contributor

While teaching beginners, they often get confused on the GraphQL part. There's a conflict on using Ctrl + Space as it opens up Mac search. As discussed here →.

The solution to this is a non-conflict key mapping which is what this PR adds for beginners.

or use <kbd>Shift + Space</kbd>

Peace! ✌️

@calcsam
Copy link
Contributor

calcsam commented Sep 23, 2018

Thanks @ahmadawais! Ctrl-Space is different than Command-Space, but easy to get confused.

Confirming that Shift-Space works on all OS-s? If so then maybe we should just recommend this instead of Command-Space (or both, eg, "Use Shift-Space, or Cmd+Space, to..."

I don't think we should use the words "conflict key mapping" in the tutorial as they're likely to confuse beginners!

@ahmadawais
Copy link
Contributor Author

Thanks @ahmadawais! Ctrl-Space is different than Command-Space, but easy to get confused.

Nops. That's not what I am saying here. CONTROL (⌃) + SPACE in MacOS opens Search This Mac Finder for me and many others.

Confirming that Shift-Space works on all OS-s? If so then maybe we should just recommend this instead of Command-Space (or both, eg, "Use Shift-Space, or Cmd+Space, to..."

It should work as mentioned in the PR I linked above. I only tested on MacOS and it does work there.

I don't think we should use the words "conflict key mapping" in the tutorial as they're likely to confuse beginners!

Should I rename it to alternate keyboard shortcut?

@calcsam
Copy link
Contributor

calcsam commented Sep 24, 2018

Sorry for the misunderstanding -- Command-Space rather than Control-Space opens Spotlight Search on my Mac. Yes, I think "alternate keyboard shortcut" is a better wording. I'll make that change, squash and merge in.

@calcsam
Copy link
Contributor

calcsam commented Sep 24, 2018

Thanks @ahmadawais!

@calcsam calcsam merged commit f9b86d0 into gatsbyjs:master Sep 24, 2018
@gatsbot
Copy link

gatsbot bot commented Sep 24, 2018

Holy buckets, @ahmadawais — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@ahmadawais ahmadawais deleted the patch-2 branch September 25, 2018 14:14
@ahmadawais
Copy link
Contributor Author

Awesome! 💯

Glad to have the second contribution on Gatsby and just ordered my 🦄 Purple T-Shirt :)

Peace! ✌️

oorestisime pushed a commit to oorestisime/gatsby that referenced this pull request Sep 28, 2018
*  📖 DOC: Non-conflict key mapping

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants