Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid gatsby-source-drupal version in package.json #8497

Merged
merged 2 commits into from Sep 26, 2018

Conversation

kakadiadarpan
Copy link
Contributor

gatsby-source-drupal doesn't have version ^2.2.0 yet. This causes yarn/npm install error

Updated it with the latest version 2.0.44

@pieh
Copy link
Contributor

pieh commented Sep 24, 2018

There is something else fishy here - it seems we didn't publish v2 stable, which should probably start with version 3.0.0 - latest stable (2.0.44) is for gatsby v1

@kakadiadarpan
Copy link
Contributor Author

kakadiadarpan commented Sep 24, 2018

@pieh I just checked the version history for gatsby-source-drupal. Before the v2 branch was merged in master, the version of gatsby-source-drupal vas 2.0.41 as it can be seen in the screenshot below:

screen shot 2018-09-24 at 7 34 48 pm

When I tried to do yarn add gatsby-source-drupal@latest it gave version 2.0.44. Also in the current master branch for gatsby-source-drupal, package.json says version is 2.2.0

@pieh
Copy link
Contributor

pieh commented Sep 24, 2018

Yeah, we need to properly release v2 version of gatsby-source-drupal then

@pieh
Copy link
Contributor

pieh commented Sep 24, 2018

ref for PR bumping major version: #8499

@kakadiadarpan
Copy link
Contributor Author

After you merge that, I'll update this PR to reflect the new version of gatsby-source-drupal

@pieh pieh merged commit c392d26 into gatsbyjs:master Sep 26, 2018
lipis added a commit to lipis/gatsby that referenced this pull request Sep 27, 2018
* 'master' of github.com:gatsbyjs/gatsby:
  Add blog post on v2 reach router (gatsbyjs#8508)
  feat: add self to community page (gatsbyjs#8572)
  feat: update sites.yml (gatsbyjs#8589)
  Add an example to the sourceNodes docs (gatsbyjs#8585)
  chore(release): Publish
  fix: add compat fix for gatsby-cli v2 with gatsby v1 (gatsbyjs#8581)
  fix: fix unhandled rejection when no browser found when running with --open flag (gatsbyjs#8507)
  Fix writing out new page information (so new pages hot reload) during development (gatsbyjs#8570)
  Run coverage at the end of jest and configure thresholds (gatsbyjs#8371)
  chore(release): Publish
  chore: update gatsby-source-drupal version in using-drupal example (gatsbyjs#8497)
  Typo fix in gatsby-source-graphql/README.md (gatsbyjs#8562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants