[www/starters] filter out invalid entries and set max number to show #8763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
approved these changes
Oct 3, 2018
amberleyromo
force-pushed
the
fix/starters-invalid-entries
branch
from
9db2ed0
to
9bc8690
Compare
|
@pieh review?
|
This was referenced Oct 19, 2018
|
I wonder if aborting the entire build because an HTTP request failed is a good idea. Instinctively, I'd guess not, but I don't have enough context to put any weight behind my instincts! I guess if GitHub is down, or the request simply fails for some reason, the current logic of setting some default data makes sense. Why that logic sometimes fails, well that's a whole different story... :-) |
chmac
reviewed
Oct 19, 2018
| let starters = data.allStartersYaml.edges | ||
| // stopgap for missing gh data (#8763) | ||
| let starters = data.allStartersYaml.edges.filter(({ node: starter }) => { | ||
| return starter.fields && starter.fields.starterShowcase |
There was a problem hiding this comment.
This seems like an ingeniously hacky solution to me. ❤️ It's an ugly fix, but should solve the current issues we're seeing with the UI breaking because this field is sometimes missing.
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…atsbyjs#8763) * [www/starters] filter out invalid entries and set max number to show * [www/starters] move load more onclick method * [www] panic on build if error fetching starter repo data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8757