Add "sourcing from Contentful" section. #8861
Conversation
Copied over https://www.gatsbyjs.org/blog/2018-1-25-building-a-site-with-react-and-contentful/#what-is-contentful-why-choose-it I still need to remove/add what's needed
alejandronanez
added
the
type: documentation
|
@alejandronanez Don't worry about the labels, you're good! Ping when you're ready for review. Quick note -- it looks like you used the full content of the blog post. It'd probably be a good start to axe the part before the Thanks for working on this! |
|
Hi @alejandronanez -- this still has some "todos" listed at the bottom. Still WIP? |
@amberleyromo do you think I should add a contentful real-world example to this doc? or is it out of the scope of this PR? If it is out of scope, this would just need a spell check and that's it! |
|
@alejandronanez I think for the sake of this PR it's out of scope -- let's make any final edits you want and get this merged! If you'd like to get this merged and then open an additional PR to flesh it out further, that would be much appreciated! |
alejandronanez
changed the title
|
Hello @amberleyromo! This is ready for review now :) |
|
This looks awesome @alejandronanez! Way to follow the headers specified in the Style Guide 👍 As far as real world examples go, you could add a section at the bottom titled "Other resources" or "further reading" to link to a blogpost, source code of an example site, outside tutorials, etc. |
|
@shannonbux thanks for the tips! 👍🏼👍🏼👍🏼 |
|
@alejandronanez Also just realized I didn't make this clear--I know this PR already got merged, and so adding a new section at the bottom would have to happen in a new PR :) Again, way to go! |
* Issue 8741: WIP Copied over https://www.gatsbyjs.org/blog/2018-1-25-building-a-site-with-react-and-contentful/#what-is-contentful-why-choose-it I still need to remove/add what's needed * Removing unuseful information from the original post! * docs: clean up documentation and mention the usage of gatsby-source-contentful plugin * Removed TODO list * Tweaks
WIP to close #8741So far I've done:- Copied over https://www.gatsbyjs.org/blog/2018-1-25-building-a-site-with-react-and-contentful/#what-is-contentful-why-choose-it I still need to remove/add what's neededWill continue with this work over the next few days!@shannonbux 👋 what should be the right labels for this besides
type: documentation? I'm still learning the ropes here 🙂Update
Reasy for review.
Closes #8714