Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hosting on netlify doc #9165

Merged
merged 3 commits into from
Oct 18, 2018
Merged

hosting on netlify doc #9165

merged 3 commits into from
Oct 18, 2018

Conversation

thakkaryash94
Copy link
Contributor

closes #8844 . This request contains documentation on how to host gatsby site on netlify. Tried to explain both ways to host gatsby website including little domain mapping instruction.

@thakkaryash94 thakkaryash94 requested review from shannonbux and a team October 16, 2018 18:51
@thakkaryash94 thakkaryash94 requested a review from a team as a code owner October 16, 2018 18:51
@pieh
Copy link
Contributor

pieh commented Oct 17, 2018

I think we will need to edit netlify section in https://github.com/gatsbyjs/gatsby/blob/master/docs/docs/deploy-gatsby.md - maybe just edit out Deploying to Netlify section and add link to this new doc?

@thakkaryash94
Copy link
Contributor Author

@pieh Done, please review and give feedback.

Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @thakkaryash94! I pushed a slight tweak to avoid the duplication of the "gatsby starter" instructions. @pieh these changes address your note about the overview doc. Once these are all sectioned out as well, that page will get a fine-tune.

@amberleyromo amberleyromo merged commit 8f0ed37 into gatsbyjs:master Oct 18, 2018
@thakkaryash94
Copy link
Contributor Author

@amberleyromo thank you for reviewing my pull request. Very happy you like it and changes you did in the beginning.

@amberleyromo
Copy link
Contributor

@thakkaryash94 thank you for your contribution!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* add hosting on netlify doc

* minor improvements, add link in deploy gatsby netlify section

* Slight tweak to eliminate quick start info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content migration - create Hosting on Netlify doc
3 participants