feat(www): custom hubspot submission for newsletter #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
approved these changes
Oct 18, 2018
| data.context.sfdcCampaignId = sfdcCampaignId | ||
| } | ||
|
|
||
| const xhr = new XMLHttpRequest() |
There was a problem hiding this comment.
:D give me some fetch love and tell world IE is not a thing anymore to not throw in polyfills :)
|
🙏 !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so this is very hacky but seems to work:
I was using my throwaway form to not mess with submissions + it didn't have "SFDC Campaign" - it should be fine (if docs at https://developers.hubspot.com/docs/methods/forms/submit_form_ajax are correct).
And also disabled default html input verification for this gif - with type="email" + required attr, field validation should be handled by browsers (with hubspot server validation being fallback)
This doesn't make use of HubSpot usertoken - but it seems we currently don't use anyway, so there shouldn't be regression in this area (please check hubspot docs linked above for explanation of the token)
Note this PR is against @fk branch that re-adds newsletter form to homepage ( #9183 )
/cc @fk @calcsam