-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-wordpress): create site metadata node #9329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stripped out again by excludeUnknownEntities.
ghost
changed the title
Feat: Added SiteMetadata as an entity and made sure it's not gettingstripped out again by excludeUnknownEntities.
Feat: Added SiteMetadata as an entity and made sure it's not getting stripped out again by excludeUnknownEntities.
Oct 23, 2018
ghost
changed the title
Feat: Added SiteMetadata as an entity and made sure it's not getting stripped out again by excludeUnknownEntities.
[gatsby-source-wordpress] Feat: Added SiteMetadata as an entity and made sure it's not getting stripped out again by excludeUnknownEntities.
Oct 24, 2018
pieh
changed the title
[gatsby-source-wordpress] Feat: Added SiteMetadata as an entity and made sure it's not getting stripped out again by excludeUnknownEntities.
feat(gatsby-source-wordpress): create site metadata node
Oct 24, 2018
ghost
requested a review
from pieh
October 24, 2018 11:24
pieh
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @openmedi!
We could follow up with updating docs on this - but functionality will be there at least |
ghost
deleted the
topics/add-wordpress-site-metadata
branch
October 24, 2018 11:32
ghost
pushed a commit
that referenced
this pull request
Oct 25, 2018
Added info about the availability of site metadata (as per [this comment](#9329 (comment)) of @pieh in #9329). I don't know if this is enough info, but I think it's pretty basic functionality, so maybe a couple of mentions are indeed enough?
ghost
mentioned this pull request
Oct 25, 2018
pieh
pushed a commit
that referenced
this pull request
Oct 25, 2018
…readme (#9399) Added info about the availability of site metadata (as per [this comment](#9329 (comment)) of @pieh in #9329). I don't know if this is enough info, but I think it's pretty basic functionality, so maybe a couple of mentions are indeed enough?
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…readme (gatsbyjs#9399) Added info about the availability of site metadata (as per [this comment](gatsbyjs#9329 (comment)) of @pieh in gatsbyjs#9329). I don't know if this is enough info, but I think it's pretty basic functionality, so maybe a couple of mentions are indeed enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8051.