Add unstructured data example #9408
Conversation
There was a problem hiding this comment.
@amberleyromo How should we handle the comparison branch here? Same idea (create a branch, link to diffs)? Something else?
|
For now I changed the README to link to the branch on your repo. These examples are supposed to be very targeted -- I think it makes sense in the context of your example repo, but is probably too confusing in the context of the monorepo. What do you think about making the "graphql" branch of this its own example? |
|
What about as a local plugin example? |
|
Hmm... I feel like the comparison between these examples is actually the most critical part. Maybe @gatsbyjs/core can weigh in here? Do we have any prior work that's comparing two approaches in Gatsby? Any ideas on how best to show that off? |
|
Making it two sites with mirrored content with different approaches could accomplish the same thing well. In the "branch" solution, we still have to message in the README to 1) look at the branch and 2) what it's accomplishing. With a "local plugin" example, we could show the gatsby-layer example, and also have it be its own standalone example -- still supported by messaging in both READMEs (same method as currently) |
|
@amberleyromo Okay, I'm sold. Sounds good! |
|
@jlengstorf Added the other example and modified both README files 👍 |
| @@ -0,0 +1,56 @@ | |||
| const axios = require("axios") | |||
There was a problem hiding this comment.
Complete and total nit-pick, but did we change something where strings use double quotes or something now? 🤷♂️
| Promise.all( | ||
| names.map(async name => { | ||
| const { data: pokemon } = await get(`/pokemon/${name}`) | ||
| const abilities = await Promise.all( |
There was a problem hiding this comment.
Minor suggestion!
| const abilities = await Promise.all( | |
| const abilities = await Promise.all( | |
| pokemon.abilities.map(({ ability: { name: abilityName } }) => | |
| get(`/ability/${abilityName}`) | |
| .then(res => res.data) | |
| ) | |
| ) |
There was a problem hiding this comment.
This looks great! Thanks for adding this, it'll be helpful to point to this!
One comment... it's not abundantly clear to me that unstructured data means not using GraphQL, and I think that's what people are going to be searching for rather than unstructured data, but I think that's probably OK!
* add @jlengstorf unstructured data in official examples * clarify other branch in README * add local plugin example (from comparison branch of unstructured data example * update local plugin example README to reference unstructured data example * update unstructured data README, and rename local plugins example dir * link out to blog post and doc page
This adds the unstructured data site example built by @jlengstorf into the
examplesdir in the gatsby repo.