Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[www] Make iPhone X compatible #9449

Merged
merged 2 commits into from
Oct 29, 2018
Merged

[www] Make iPhone X compatible #9449

merged 2 commits into from
Oct 29, 2018

Conversation

gurtjun
Copy link
Contributor

@gurtjun gurtjun commented Oct 26, 2018

This should fix #9448.
Also added padding to the banner, layout and desktop navigation to make sure it also works in landscape mode on the iPhone X
img_0218

@gurtjun gurtjun requested review from a team as code owners October 26, 2018 18:21
@gurtjun gurtjun mentioned this pull request Oct 26, 2018
Closed
DSchau
DSchau suggested changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just not sure about the change to cache-dir/default-html.js!

Thank you so much for the contribution!

packages/gatsby/cache-dir/default-html.js Outdated Show resolved Hide resolved
@gurtjun
Copy link
Contributor Author

gurtjun commented Oct 27, 2018

@DSchau I moved the meta to react-helmet in layout.js to make sure it only affects the GatsbyJS website.

@gurtjun
Copy link
Contributor Author

gurtjun commented Oct 27, 2018 •
edited

Not sure why the AppVeyor build failed though, gatsbygram example builds successful locally. Is it possible to re-run this?

@thorn0
Copy link
Contributor

thorn0 commented Oct 29, 2018

@gurtjun You can close and reopen the PR to rerun the checks.

@gurtjun
Copy link
Contributor Author

gurtjun commented Oct 29, 2018

@gurtjun You can close and reopen the PR to rerun the checks.

I reworded my commit message to rerun the checks, but it's still failing.
Seems that it goes wrong when running yarn run build in /examples/gatsbygram in AppVeyor, but it's working on my machine. Can someone confirm that it's also working at their end?

@gurtjun gurtjun closed this Oct 29, 2018
@gurtjun gurtjun reopened this Oct 29, 2018
@gurtjun
Copy link
Contributor Author

gurtjun commented Oct 29, 2018

@DSchau @thorn0 Seems that now all checks are passed without changing anything. Strange but cool 👍

@DSchau
Copy link
Contributor

DSchau commented Oct 29, 2018

@gurtjun the Windows PRs (Appveyor) tend to be a little flaky. We're working on improving them from a consistency basis! Taking a look at this PR now.

DSchau
DSchau approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. You checked this out on a real device (or iPhone X simulator) correct?

@fk look good to you?

@gurtjun
Copy link
Contributor Author

gurtjun commented Oct 29, 2018

I checked this out on a real device.

fk
fk approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSchau LGTM!
@gurtjun Thanks for taking this on! 🙏 🤗

@DSchau DSchau merged commit 0f2913d into gatsbyjs:master Oct 29, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 29, 2018

Holy buckets, @gurtjun — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@gurtjun gurtjun deleted the feature/www-iphone-x branch October 30, 2018 10:15
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@gurtjun @gpetrioli
[www] Make iPhone X compatible (gatsbyjs#9449)
5af9c4d 
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

This should fix gatsbyjs#9448. 
Also added padding to the banner, layout and desktop navigation to make sure it also works in landscape mode on the iPhone X
![img_0218](https://user-images.githubusercontent.com/13830735/47585018-794b5980-d95c-11e8-9a4e-8d7da85c47e6.PNG)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fk fk fk approved these changes

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[www] Not optimised for iPhone X
4 participants
@gurtjun @thorn0 @DSchau @fk