Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestingJavaScript.com to showcase #9474

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Add TestingJavaScript.com to showcase #9474

merged 1 commit into from
Oct 27, 2018

Conversation

mingaldrichgan
Copy link
Contributor

From the latest newsletter from Kent C. Dodds:

The number one question I get asked about TestingJavaScript.com: I'm seeing an outdated version of the site! I don't see a "buy" button anywhere!!!

The answer to this is simple and slightly embarrassing... Workbox (a library that Gatsby's offline plugin used) had a bug and your browser has it. We fixed the problem on the site, but there's no way for us to force your browser to update due to this bug. Try clearing the site data in your browser settings or use another browser.

Of interest here is the fact that it uses Gatsby, hence this pull request. :-)

@mingaldrichgan mingaldrichgan requested a review from a team October 27, 2018 13:05
KyleAMathews
KyleAMathews approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit 004c875 into gatsbyjs:master Oct 27, 2018
@mingaldrichgan mingaldrichgan deleted the testingjavascript branch October 27, 2018 20:45
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@mingaldrichgan @gpetrioli
Add TestingJavaScript.com to showcase (gatsbyjs#9474)
40db7ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mingaldrichgan @KyleAMathews