Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis-ci integration + eslint + ES2015 #96

Merged
merged 3 commits into from Dec 20, 2015
Merged

Add travis-ci integration + eslint + ES2015 #96

merged 3 commits into from Dec 20, 2015

Conversation

KyleAMathews
Copy link
Contributor

Cleanup our source. Add eslint (airbnb's) + Travis CI check. This is first step to actually getting tests running as well.

  • fix eslint errors.
  • Add build step to prepublish to compile ES6
  • Use Babel source still if using checked-out and npm linked.
  • Pull out eslint config into separate repo like in Rackt https://github.com/rackt/eslint-config-rackt

ChristopherBiscardi
ChristopherBiscardi reviewed Dec 1, 2015
View reviewed changes
.travis.yml
node_js:
- "0.10"
- "0.12"
- "4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 5 could also be added here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added osx.

@KyleAMathews KyleAMathews force-pushed the add-travis-linting branch 3 times, most recently from 3ce6a55 to a7df01e Compare December 1, 2015 18:47
@KyleAMathews KyleAMathews changed the title WIP: Add travis-ci integration + eslint + ES2015 Add travis-ci integration + eslint + ES2015 Dec 20, 2015
@KyleAMathews
Copy link
Contributor Author

ESLint config still needs pulled out to another repo and added to the Gatsby starter repos.

KyleAMathews added a commit that referenced this pull request Dec 20, 2015
@KyleAMathews
Merge pull request #96 from gatsbyjs/add-travis-linting
2b0fffa 
Add travis-ci integration + eslint + ES2015
@KyleAMathews KyleAMathews merged commit 2b0fffa into master Dec 20, 2015
@0x80 0x80 deleted the add-travis-linting branch April 19, 2017 20:22
This was referenced Feb 19, 2022
Merged
Open
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@marcobiedermann
feature: add missing PropType validation to Header component - fix ga…
769a78c 
…tsbyjs#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KyleAMathews @ChristopherBiscardi