Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving unit-testing.md #9825

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Improving unit-testing.md #9825

merged 1 commit into from
Nov 12, 2018

Conversation

RobinCsl
Copy link
Contributor

@RobinCsl RobinCsl commented Nov 8, 2018

Following suggestions from @shannonbux to improve unit-testing.md further

@RobinCsl RobinCsl requested a review from a team November 8, 2018 21:54
Copy link
Contributor

@calcsam calcsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RobinCsl !

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; let's merge. Thank you!

@DSchau DSchau merged commit 8f32dd6 into master Nov 12, 2018
@DSchau DSchau deleted the RobinCsl-patch-unit-testing-md branch November 12, 2018 15:21
@shannonbux
Copy link
Contributor

Thanks @RobinCsl and @DSchau! Looks great!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Following [suggestions](gatsbyjs#9795 (comment)) from @shannonbux to improve `unit-testing.md` further

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants