Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to Jason Lengstorf's personal website. #9910

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

papaponmx
Copy link
Contributor

The link is now directed where it is supposed to

The link is now directed where it is supposed to
@papaponmx papaponmx requested a review from a team November 13, 2018 22:13
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that the link is broken, but I don't think this is an improvement!

In the context of this document, we want to link to the actual source code, since it's helpful to see "SEO components" in the wild.

I've added a suggestion!

docs/docs/seo.md Outdated Show resolved Hide resolved
Updated link.

Co-Authored-By: papaponmx <jaimemadrigalrios@gmail.com>
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@DSchau DSchau merged commit 7bd7bbc into gatsbyjs:master Nov 13, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 13, 2018

Holy buckets, @papaponmx — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Nov 13, 2018

We should target specific ref/commit (not master branch) - this will get out of sync again otherwise

jlengstorf pushed a commit to jlengstorf/gatsby that referenced this pull request Nov 14, 2018
The link is now directed where it is supposed to
@DSchau
Copy link
Contributor

DSchau commented Nov 14, 2018

@pieh I originally had it that way, but then moved it back to master. It was intentional. I feel like if updates to those components are made, we'll want them 🤷‍♂️

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
The link is now directed where it is supposed to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants