-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated link to Jason Lengstorf's personal website. #9910
Conversation
The link is now directed where it is supposed to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that the link is broken, but I don't think this is an improvement!
In the context of this document, we want to link to the actual source code, since it's helpful to see "SEO components" in the wild.
I've added a suggestion!
Updated link. Co-Authored-By: papaponmx <jaimemadrigalrios@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Holy buckets, @papaponmx — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
We should target specific ref/commit (not master branch) - this will get out of sync again otherwise |
The link is now directed where it is supposed to
@pieh I originally had it that way, but then moved it back to master. It was intentional. I feel like if updates to those components are made, we'll want them 🤷♂️ |
The link is now directed where it is supposed to
The link is now directed where it is supposed to